Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not override last error #1584

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Do not override last error #1584

merged 5 commits into from
Dec 18, 2024

Conversation

KsaweryZietara
Copy link
Contributor

@KsaweryZietara KsaweryZietara commented Dec 18, 2024 •
edited
Loading

Description

After changes introduced in #1177, lastError is set in OperationFailed function.

Changes proposed in this pull request:

  • remove unnecessary lastError overwrite,
  • set reason, component and step even if error is nil.

Related issue(s)
See also #1177

@KsaweryZietara KsaweryZietara added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Dec 18, 2024
@KsaweryZietara KsaweryZietara self-assigned this Dec 18, 2024
@KsaweryZietara KsaweryZietara requested a review from a team as a code owner December 18, 2024 07:53
@KsaweryZietara KsaweryZietara added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Dec 18, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) December 18, 2024 07:53
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 18, 2024
@KsaweryZietara KsaweryZietara removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit 14c8926 into kyma-project:main Dec 18, 2024
29 of 31 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@KsaweryZietara KsaweryZietara mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@KsaweryZietara KsaweryZietara

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KsaweryZietara @jaroslaw-pieszka @kyma-bot @kyma-gopher-bot